Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SQLSERVER to valid values of aws_db_proxy.engine_family #32117

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Add SQLSERVER to valid values of aws_db_proxy.engine_family #32117

merged 1 commit into from
Jun 21, 2023

Conversation

justinretzolk
Copy link
Member

Description

This PR intends to add SQLSERVER to the valid values for the engine_family argument of the aws_db_proxy resource. In doing so, I've also pulled in a bit of additional information that's found in the related AWS documentation (linked below).

Relations

Closes #32092

References

Output from Acceptance Testing

N/a, docs

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. labels Jun 20, 2023
jar-b
jar-b approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@justinretzolk justinretzolk merged commit 0c88e7b into main Jun 21, 2023
@justinretzolk justinretzolk deleted the d-db_proxy-engine_family branch June 21, 2023 13:56
@github-actions github-actions bot added this to the v5.5.0 milestone Jun 21, 2023
@github-actions
Copy link

This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v5.5.0
Development

Successfully merging this pull request may close these issues.

[Docs]: rds proxy SQLSERVER
2 participants
@justinretzolk @jar-b